[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

[Alexey Bader via Phabricator via cfe-commits]

bader added a comment.

@hvdijk, thanks a lot for fixing this.

In D147097#4229121 <https://reviews.llvm.org/D147097#4229121>, @hvdijk wrote:

> Is the rationale I gave in the description correct, or would it be better for SYCL device code to unconditionally build without `-fexceptions` and get the `nounwind` attribute added that way?

That's a good question. I haven't looked into this issue deep enough, but I think using `-fexceptions` requires using delayed diagnostics to avoid false diagnostics during host code analysis. 
Anyway, all GPU offloading single-source modes have the same restriction and design and we better have unified solution whether it's using `-fexceptions` or adding `nounwind` attribute in CodeGen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147097/new/

https://reviews.llvm.org/D147097