[PATCH] D146875: [clang-tidy] Fix example provided by add_new_check.py

[Piotr Zegar via Phabricator via cfe-commits]

PiotrZSL added a comment.

I know that it would be better, best would be to remove that --fix-notes completely and enable those notes fixes with basic --fix, as it only create confusion.

Originally it were like this:
"Added an option to control whether to apply the fixes found in notes attached to clang tidy errors or not.
 Diagnostics may contain multiple notes each offering different ways to fix the issue, for that reason the default behaviour should be to not look at fixes found in notes.
 Instead offer up all the available fix-its in the output but don't try to apply the first one unless `-fix-notes` is supplied.
"
Commit: abbe9e227ed31e5dde9bb7567bb9f0dd047689c6 <https://reviews.llvm.org/rGabbe9e227ed31e5dde9bb7567bb9f0dd047689c6>

But that is stupid, because there could be conflicts between those fixes.
And this were added by D59932 <https://reviews.llvm.org/D59932>.

@njames93 What do you think, after all you broke this.
Option A) Change generator to attach fix to warning instead of note.
Option B) Revert your commit that introduced --fix-notes
Option C) Introduce option --dont-fix-notes, and enable notes fixes by default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146875/new/

https://reviews.llvm.org/D146875