[PATCH] D147081: [clang-tidy] Fix issues in bugprone-assert-side-effect

[Piotr Zegar via Phabricator via cfe-commits]

PiotrZSL created this revision.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
PiotrZSL requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.

- Fixed problem when after changes in macros handling in Clang-tidy 14 cased issues from from this check be hidden when assert is defined in system headers. Now raising diagnostic for a place from where macro is called.
- Added support for const, pure, constexpr functions/methods. Now they considered safe.
- Split configuration options CheckFunctionCalls, IgnoredFunctions, to support enabling only checking of methods, or only of functions.

Fixes: #47605, #25569, #31821


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147081

Files:
  clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp
  clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.h
  clang-tools-extra/docs/ReleaseNotes.rst
  clang-tools-extra/docs/clang-tidy/checks/bugprone/assert-side-effect.rst
  clang-tools-extra/test/clang-tidy/checkers/bugprone/Inputs/assert-side-effect/assert.h
  clang-tools-extra/test/clang-tidy/checkers/bugprone/assert-side-effect-constexpr.cpp
  clang-tools-extra/test/clang-tidy/checkers/bugprone/assert-side-effect.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147081.509124.patch
Type: text/x-patch
Size: 14991 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230328/de61eb6e/attachment-0001.bin>