[PATCH] D147062: [clang-tidy] Add option to ignore capture default by reference in cppcoreguidelines-avoid-capture-default-when-capturing-this

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 28 13:20:09 PDT 2023


carlosgalvezp added a comment.

In D147062#4228403 <https://reviews.llvm.org/D147062#4228403>, @ccotter wrote:

> If https://github.com/isocpp/CppCoreGuidelines/issues/2060 is accepted to only consider `[=]`, then I assume we'd want to change the default value of IgnoreCaptureDefaultByReference to be true?  Thanks by the way for this!

Thanks for reviewing! If they do accept it (I'm not very optimistic) then I'd probably just remove this logic and exit early if the lambda capture is not `LCD_ByCopy`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147062/new/

https://reviews.llvm.org/D147062



More information about the cfe-commits mailing list