[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

Christopher Di Bella via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 28 09:58:31 PDT 2023


cjdb added a comment.

In D146358#4204412 <https://reviews.llvm.org/D146358#4204412>, @tbaeder wrote:

> "subobject named 'foo'" sounds a bit weird to me, I'd expect just "subobject 'foo'", but that's just a suggestion and I'll wait for a native spearker to chime in on this.

My expert brain likes `subobject of type 'T'`, but it's very wordy, and potentially not useful additional info. I'm partial to `subobject 'T'` due to it being the thing we're more likely to say in conversation (e.g. "that `int` isn't initialised"). I've also put out a mini-survey on the #include <C++> Discord server, and will update in a few hours.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146358/new/

https://reviews.llvm.org/D146358



More information about the cfe-commits mailing list