[PATCH] D146971: [Sema] Populate declarations inside TypeLocs for some invalid types

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 28 07:37:56 PDT 2023


aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM, though the change should come with a release note. Suggestion you can take or leave as you see fit: should we turn the places where we removed the null pointer check into assertions that the pointer is nonnull? Or are we hoping the crash will be sufficient to tell us when we've missed a case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146971/new/

https://reviews.llvm.org/D146971



More information about the cfe-commits mailing list