[PATCH] D146885: [clang-tidy][NFC] add debug log when clean empty namespace

Piotr Zegar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 28 07:26:35 PDT 2023


PiotrZSL requested changes to this revision.
PiotrZSL added a comment.
This revision now requires changes to proceed.

This shouldn't be delivered. Do such tests, locally, instead of committing them.
This change impact clang, and all tools, not only clang-tidy, therfor [clang-tidy] prefix is misleading.

Issue related to modernize-concat-nested-namespaces should be fixed by clang-tidy itself.
It's visible in AST, so clang-tidy could fix it.

  TranslationUnitDecl
  `-NamespaceDecl <line:1:1, line:3:1> line:1:11 a
    `-NamespaceDecl <line:2:1, col:14> col:11 b

For me this change should be abandoned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146885/new/

https://reviews.llvm.org/D146885



More information about the cfe-commits mailing list