[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

Tue Mar 28 06:52:58 PDT 2023

qiongsiwu1 added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:714-716
+    if (!Args.hasFlag(options::OPT_fdata_sections,
+                      options::OPT_fno_data_sections, UseSeparateSections) &&
+        Args.hasArg(options::OPT_fno_data_sections))
----------------
hubert.reinterpretcast wrote:
> I think this (undesirably) generates an error even `-mno-roptr` is in effect.
> 
> This logic seems otherwise convoluted. I think the main logic should only care that `data-sections` is off. We can separately assert that `data-sections` is on by default on AIX.
Thanks for catching the error! I am updating the patch to fix the undesirable error. 

The checking logic is to make sure we are consistent with how we set `-data-sections=0` above (line 705). I will revise the logic to check `no_data_sections` if we are ok with the inconsistency. @hubert.reinterpretcast could you confirm? Thanks! 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144190/new/

https://reviews.llvm.org/D144190