[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass
Andrzej Warzynski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 28 06:19:40 PDT 2023
awarzynski added a comment.
Thanks for the explanation! Still looking good apart from the function names ;)
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:111
+llvm::codegenoptions::DebugInfoKind
+DebugLevelToInfoKind(const llvm::opt::Arg &A);
+
----------------
awarzynski wrote:
> CamelCase or camelCase? ;-)
Sorry, I meant that this function uses wrong casing. It ought to be `debugLevelToInfoKind` and `addDebugInfoKind`: https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146814/new/
https://reviews.llvm.org/D146814
More information about the cfe-commits
mailing list