[clang] 1bc2d43 - [clang][dataflow][NFC] Put TransferVisitor in an unnamed namespace.

Martin Braenne via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 28 03:04:00 PDT 2023


Author: Martin Braenne
Date: 2023-03-28T10:03:39Z
New Revision: 1bc2d43e5c8fd0ec2e1a7e364fb42272ed7fb158

URL: https://github.com/llvm/llvm-project/commit/1bc2d43e5c8fd0ec2e1a7e364fb42272ed7fb158
DIFF: https://github.com/llvm/llvm-project/commit/1bc2d43e5c8fd0ec2e1a7e364fb42272ed7fb158.diff

LOG: [clang][dataflow][NFC] Put TransferVisitor in an unnamed namespace.

This avoids the risk of ODR violations.

Reviewed By: gribozavr2

Differential Revision: https://reviews.llvm.org/D147032

Added: 
    

Modified: 
    clang/lib/Analysis/FlowSensitive/Transfer.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Analysis/FlowSensitive/Transfer.cpp b/clang/lib/Analysis/FlowSensitive/Transfer.cpp
index be5c9992a6d9d..d255d27e52c45 100644
--- a/clang/lib/Analysis/FlowSensitive/Transfer.cpp
+++ b/clang/lib/Analysis/FlowSensitive/Transfer.cpp
@@ -139,6 +139,8 @@ static Value *maybeUnpackLValueExpr(const Expr &E, Environment &Env) {
   return &UnpackedVal;
 }
 
+namespace {
+
 class TransferVisitor : public ConstStmtVisitor<TransferVisitor> {
 public:
   TransferVisitor(const StmtToEnvMap &StmtToEnv, Environment &Env)
@@ -884,6 +886,8 @@ class TransferVisitor : public ConstStmtVisitor<TransferVisitor> {
   Environment &Env;
 };
 
+} // namespace
+
 void transfer(const StmtToEnvMap &StmtToEnv, const Stmt &S, Environment &Env) {
   TransferVisitor(StmtToEnv, Env).Visit(&S);
 }


        


More information about the cfe-commits mailing list