[PATCH] D146678: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 27 22:35:07 PDT 2023


shafik added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:843
   Expr *NewIDC = ConceptSpecializationExpr::Create(
-      C, CSE->getNamedConcept(), CSD, nullptr, CSE->isInstantiationDependent(),
-      CSE->containsUnexpandedParameterPack());
+      C, CSE->getNamedConcept(), CSE->getTemplateArgsAsWritten(), CSD, nullptr,
+      CSE->isInstantiationDependent(), CSE->containsUnexpandedParameterPack());
----------------
nit follow clang-tidy [bugprone-argument-comment convention](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146678/new/

https://reviews.llvm.org/D146678



More information about the cfe-commits mailing list