[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

[Jacob Lambert via Phabricator via cfe-commits]

lamb-j added a comment.

In D145770#4220246 <https://reviews.llvm.org/D145770#4220246>, @mdtoguchi wrote:

> @lamb-j - is it expected for any bundled objects created before your change without the explicit env field to be able to be unbundled?  Newly generated bundles work as expected given similar `-target` values, but older generated binaries fail to unbundle the target given equivalent commands.  Is it possible to provide the ability to do so?

That should still be supported. The target triple for the old bundle should be converted to the new format (and compared against the Target-ID that was also converted to the new format). Can you provide an example to recreate the failure? I just tried one example locally and didn't hit any failures:

  old-clang -c --offload-arch=gfx906 -emit-llvm -fgpu-rdc --gpu-bundle-output square.hip
  new-clang-offload-bundler -unbundle -type=bc -targets=hip-amdgcn-amd-amdhsa-gfx906 -input=square.bc -output=square-hip-gfx906.bc -allow-missing-bundles -debug-only=CodeObjectCompatibility
  
  Compatible: Exact match:        [CodeObject: hip-amdgcn-amd-amdhsa--gfx906]     :       [Target: hip-amdgcn-amd-amdhsa--gfx906]


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145770/new/

https://reviews.llvm.org/D145770