[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

Mon Mar 27 13:00:54 PDT 2023

jp4a50 added a comment.

I've removed the special-casing that I added for namespace scope statements. If I make those changes at all, I'll raise them as a follow up diff.

================
Comment at: clang/unittests/Format/FormatTest.cpp:21953
-  verifyFormat("std::sort(v.begin(), v.end(),\n"
-               "          [](const auto &someLongArgumentName, const auto "
-               "&someOtherLongArgumentName) {\n"
----------------
MyDeveloperDay wrote:
> I would think the point here is to test someLongArgumentName not to use a small variable like 'v'
These changes have been moved to D146995 now, but I'll respond here: the long variable names were (presumably) being used to cause a line break. Since I've reduced the column limit from 100 to 60, `v` is now sufficient (and less noisy to read).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146042/new/

https://reviews.llvm.org/D146042