[PATCH] D146595: [clang] Add clang trampoline_mangled_target attribute

Mon Mar 27 12:17:51 PDT 2023

augusto2112 added a comment.

In D146595#4225170 <https://reviews.llvm.org/D146595#4225170>, @aaron.ballman wrote:

> In D146595#4225132 <https://reviews.llvm.org/D146595#4225132>, @aprantl wrote:
>
>> In D146595#4225048 <https://reviews.llvm.org/D146595#4225048>, @dblaikie wrote:
>>
>>> I know this is a bit of a redirection/scope creep/etc - but I'd quite like to see a solution that is likely to be usable for the "std::function" problem (stepping into std::function should allow you to reach the underlying function - but lldb currently skips any call to a std-namespaced function, I think, so you step right over the whole op() call) that could also cover the Swift needs. Though perhaps they're just sufficiently different problems that there is no generalizing here.
>>
>> This patch aims at exposing an existing LLVM IR & DWARF feature in clang. Having a generic solution for the std::function problem is definitely worthwhile investigating, but I'm not sure it needs to prevent supporting the existing mechanism in clang.
>
> Why should this feature be limited to DWARF? Don't we have the same kind of stepping behavior issue with PDB files, for example?

There's already support to threading trampoline names from IR to DWARF. If PDB supports the same attribute in some form there's nothing stopping someone to adding support to thread the attribute from IR to PDB as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146595/new/

https://reviews.llvm.org/D146595