[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

[Wolfgang Pieb via Phabricator via cfe-commits]

wolfgangp added inline comments.


================
Comment at: clang/test/SemaCXX/dllexport.cpp:437
 
+class Base {};
+class __declspec(dllexport) ExportedClass {};
----------------
hans wrote:
> Is this one used somewhere?
It's not. Thanks for finding it.


================
Comment at: clang/test/SemaCXX/dllexport.cpp:439
+class __declspec(dllexport) ExportedClass {};
+class __declspec(dllimport) ImportedClass {};
+
----------------
hans wrote:
> Just to double check: this case (non-template base class) worked before this patch too, right?
Right. I just added the case for good measure. Our case is about allowing a dll{ex,im}ported class that is called into existence, so to speak (i.e. instantiated), with template arguments that cause it to have non-external linkage. There is no question about the linkage of the non-template base classes. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146338/new/

https://reviews.llvm.org/D146338