[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Mon Mar 27 10:55:45 PDT 2023

Febbe added a comment.

In D137205#4224236 <https://reviews.llvm.org/D137205#4224236>, @firewave wrote:

> Some additional thoughts I had a while ago about something I have raised before:
> I think the warnings which can only be fixed with c++14 should either only be issued if that standard was specified or be behind an option. We have lots of lambda captures which could be moved with c++14 and having those warnings would lead to lots of suppressions within the code since we only target c++11.

Yes, I agree, while I can't understand, why someone still wants to use only c++11 I can totally understand, that a single Software Engineer can't do anything about this, when the corporation does not permit it. 
But it should not be removed, since this warning can still show some pitfalls in performance critical code. A way in c++11 to fix the warning, is to create a functor, instead of a lambda.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137205/new/

https://reviews.llvm.org/D137205