[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

[Tomas Matheson via Phabricator via cfe-commits]

tmatheson added a comment.

LGTM, but I'm not that familiar with the code that selects the alignment so it would be good to get a second opinion.



================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:5806
   if (!IsWinVariadic && isHomogeneousAggregate(Ty, Base, Members)) {
     if (Kind != AArch64ABIInfo::AAPCS)
       return ABIArgInfo::getDirect(
----------------
Should this change cover AAPCS_VFP too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146242/new/

https://reviews.llvm.org/D146242