[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

[Bjorn Pettersson via Phabricator via cfe-commits]

bjope added a comment.

This seem to case problems when building with asan enabled (LLVM_USE_SANITIZER='Address'):

  Failed Tests (24):
    Clang :: CXX/basic/basic.link/p2.cpp
    Clang :: CXX/basic/basic.lookup/basic.lookup.argdep/p5-ex2.cpp
    Clang :: CXX/basic/basic.scope/basic.scope.namespace/p2.cpp
    Clang :: CXX/module/basic/basic.def.odr/p4.cppm
    Clang :: CXX/module/basic/basic.def.odr/p6.cppm
    Clang :: CXX/module/basic/basic.link/module-declaration.cpp
    Clang :: CXX/module/basic/basic.link/p2.cppm
    Clang :: CXX/module/dcl.dcl/dcl.module/dcl.module.import/p1.cppm
    Clang :: CXX/module/dcl.dcl/dcl.module/dcl.module.interface/p1.cppm
    Clang :: CXX/module/dcl.dcl/dcl.module/p1.cpp
    Clang :: CXX/module/dcl.dcl/dcl.module/p5.cpp
    Clang :: CXX/module/module.interface/p1.cpp
    Clang :: CXX/module/module.interface/p2.cpp
    Clang :: CXX/module/module.unit/p8.cpp
    Clang :: CodeGenCXX/cxx20-module-impl-1a.cpp
    Clang :: CodeGenCXX/module-intializer.cpp
    Clang :: Modules/cxx20-10-1-ex1.cpp
    Clang :: Modules/cxx20-10-1-ex2.cpp
    Clang :: Modules/cxx20-10-2-ex5.cpp
    Clang :: Modules/cxx20-10-3-ex2.cpp
    Clang :: Modules/cxx20-impl-module-conditionally-load.cppm
    Clang :: Modules/cxx20-import-diagnostics-a.cpp
    Clang :: Modules/cxx20-partition-redeclarations.cpp
    Clang :: Modules/pr58532.cppm

Here is a typical log from Modules/cxx20-partition-redeclarations.cpp:

  ==80746==ERROR: LeakSanitizer: detected memory leaks
  
  Direct leak of 2080 byte(s) in 1 object(s) allocated from:
      #0 0x61ea6d in operator new(unsigned long) /repo/old//compiler-rt/lib/asan/asan_new_delete.cpp:99:3
      #1 0x11a9ae7a in clang::ModuleMap::createModuleUnitWithKind(clang::SourceLocation, llvm::StringRef, clang::Module::ModuleKind) /repo/clang/lib/Lex/ModuleMap.cpp:894:7
      #2 0x11a9bc57 in clang::ModuleMap::createModuleForImplementationUnit(clang::SourceLocation, llvm::StringRef) /repo/clang/lib/Lex/ModuleMap.cpp:933:7
      #3 0xe84a76d in clang::Sema::ActOnModuleDecl(clang::SourceLocation, clang::SourceLocation, clang::Sema::ModuleDeclKind, llvm::ArrayRef<std::__1::pair<clang::IdentifierInfo*, clang::SourceLocation>>, llvm::ArrayRef<std::__1::pair<clang::IdentifierInfo*, clang::SourceLocation>>, clang::Sema::ModuleImportState&) /repo/clang/lib/Sema/SemaModule.cpp:350:17
      #4 0xd347fc5 in clang::Parser::ParseModuleDecl(clang::Sema::ModuleImportState&) /repo/clang/lib/Parse/Parser.cpp:2478:18
      #5 0xd3451b4 in clang::Parser::ParseTopLevelDecl(clang::OpaquePtr<clang::DeclGroupRef>&, clang::Sema::ModuleImportState&) /repo/clang/lib/Parse/Parser.cpp:658:14
      #6 0xd343014 in clang::Parser::ParseFirstTopLevelDecl(clang::OpaquePtr<clang::DeclGroupRef>&, clang::Sema::ModuleImportState&) /repo/clang/lib/Parse/Parser.cpp:593:26
      #7 0xd32c624 in clang::ParseAST(clang::Sema&, bool, bool) /repo/clang/lib/Parse/ParseAST.cpp:161:25
      #8 0x9a0a494 in clang::FrontendAction::Execute() /repo/clang/lib/Frontend/FrontendAction.cpp:1058:8
      #9 0x98025a0 in clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) /repo/clang/lib/Frontend/CompilerInstance.cpp:1048:33
      #10 0x9ca0f3d in clang::ExecuteCompilerInvocation(clang::CompilerInstance*) /repo/clang/lib/FrontendTool/ExecuteCompilerInvocation.cpp:264:25
      #11 0x63ad58 in cc1_main(llvm::ArrayRef<char const*>, char const*, void*) /repo/clang/tools/driver/cc1_main.cpp:251:15
      #12 0x62d5cc in ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&, llvm::ToolContext const&) /repo/clang/tools/driver/driver.cpp:366:12
      #13 0x628173 in clang_main(int, char**, llvm::ToolContext const&) /repo/clang/tools/driver/driver.cpp:407:12
      #14 0x65de41 in main /repo/tools/clang/tools/driver/clang-driver.cpp:15:10
      #15 0x7fd7c0406554 in __libc_start_main (/lib64/libc.so.6+0x22554)
  
  SUMMARY: AddressSanitizer: 2080 byte(s) leaked in 1 allocation(s).

It is for example seen in this buildbot (sanitizer-x86_64-linux-bootstrap-asan): https://lab.llvm.org/buildbot/#/builders/168


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126959/new/

https://reviews.llvm.org/D126959