[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.
garvit gupta via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Mar 25 11:31:51 PDT 2023
garvitgupta08 added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:976-985
+ bool IsInputTyAsm = false;
+ for (const auto &II : Inputs) {
+ CmdArgs.push_back(II.getFilename());
+ StringRef BaseInput = StringRef(II.getBaseInput());
+ types::ID InputType = types::lookupTypeForExtension(
+ llvm::sys::path::extension(BaseInput).drop_front());
+ if (InputType == types::TY_Asm || InputType == types::TY_PP_Asm)
----------------
nickdesaulniers wrote:
> Thinking about this more, does the issue still exist if the user passed .c and .s/.S files together?
>
> i.e. `$ clang ... -fno-integrated-as -gdwarf-4 foo.s main.c`?
Yes, the error will still be thrown for c/cpp files.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145726/new/
https://reviews.llvm.org/D145726
More information about the cfe-commits
mailing list