[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

[kiwixz via Phabricator via cfe-commits]

kiwixz added a comment.

Your understanding is correct, I'm currently just trying to hide them at the end (warnings-as-errors or not).
This is how it worked until 5d12b13b0b26bc58b02ee23c369da8b83240cceb <https://reviews.llvm.org/rG5d12b13b0b26bc58b02ee23c369da8b83240cceb> (present in LLVM 16) which inadvertently bypass the filters with warnings-as-errors.

Note that I'm just trying to restore the previous behavior, while I'm sure PiotrZSL and others will make the whole thing more elegant for next releases.
My hope here is to fix LLVM 16 so we don't have errors that we explicitly disabled showing up, and only when enabling warnings-as-errors.

My patch does two things:

- deleting the two lines in ClangTidyDiagnosticConsumer.cpp which introduced the new and bad behavior
- adding two lines in ClangTidy.cpp to classify warnings as errors when appropriate in the YAML (this was the goal of the aforementioned commit)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146520/new/

https://reviews.llvm.org/D146520