[PATCH] D146441: [APFloat] Add E4M3B11FNUZ

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 25 05:19:22 PDT 2023


aaron.ballman added inline comments.


================
Comment at: clang/lib/AST/MicrosoftMangle.cpp:848
   case APFloat::S_Float8E4M3FNUZ:
+  case APFloat::S_Float8E4M3B11FNUZ:
     llvm_unreachable("Tried to mangle unexpected APFloat semantics");
----------------
Why are there no changes needed for the Itanium mangler? And when did we start adding a bunch of esoteric float formats? Was there an RFC for this that I missed? (If I did miss something, then sorry for the noise.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146441/new/

https://reviews.llvm.org/D146441



More information about the cfe-commits mailing list