[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

Jun Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 25 04:38:40 PDT 2023


junaire added reviewers: aaron.ballman, tbaeder, shafik.
junaire added a comment.

I don't have enough context on this patch, but obviously, there's something you can improve.

1. You need to add a test, maybe somewhere in `clang/test/Sema/`
2. Please make a detailed summary of your patch so reviewers know what's going on here. You can also link the GitHub issue.



================
Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:9
 
-//----------------understanding syntax of diagnostics messages--------===//
-//keyword after def represents symbolic constant for that diagnostics 
----------------
Why delete these? Looks like unrelated changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146867/new/

https://reviews.llvm.org/D146867



More information about the cfe-commits mailing list