[PATCH] D146864: [dataflow] Delete legacy aliases

[Sam McCall via Phabricator via cfe-commits]

sammccall created this revision.
sammccall added a reviewer: ymandel.
Herald added subscribers: martong, jeroen.dobbelaere, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
sammccall requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

I can't find any trace of use anymore.
I'm not sure renaming the header is worth the break, but leave the FIXME.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146864

Files:
  clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h


Index: clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h
===================================================================
--- clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h
+++ clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h
@@ -6,7 +6,7 @@
 //
 //===----------------------------------------------------------------------===//
 //
-//  This file defines the `MatchSwitch` abstraction for building a "switch"
+//  This file defines the `ASTMatchSwitch` abstraction for building a "switch"
 //  statement, where each case of the switch is defined by an AST matcher. The
 //  cases are considered in order, like pattern matching in functional
 //  languages.
@@ -17,8 +17,7 @@
 //
 //===----------------------------------------------------------------------===//
 //
-// FIXME: Rename to ASTMatchSwitch.h and update documentation when all usages of
-// `MatchSwitch` are updated to `ASTMatchSwitch<Stmt>`
+// FIXME: Rename to ASTMatchSwitch.h
 
 #ifndef LLVM_CLANG_ANALYSIS_FLOWSENSITIVE_MATCHSWITCH_H_
 #define LLVM_CLANG_ANALYSIS_FLOWSENSITIVE_MATCHSWITCH_H_
@@ -69,11 +68,6 @@
 using ASTMatchSwitch =
     std::function<Result(const BaseT &, ASTContext &, State &)>;
 
-// FIXME: Remove this alias when all usages of `MatchSwitch` are updated to
-// `ASTMatchSwitch<Stmt>`.
-template <typename State, typename Result = void>
-using MatchSwitch = ASTMatchSwitch<Stmt, State, Result>;
-
 /// Collects cases of a "match switch": a collection of matchers paired with
 /// callbacks, which together define a switch that can be applied to a node
 /// whose type derives from `BaseT`. This structure can simplify the definition
@@ -171,11 +165,6 @@
   std::vector<MatchSwitchAction<BaseT, State, Result>> Actions;
 };
 
-// FIXME: Remove this alias when all usages of `MatchSwitchBuilder` are updated
-// to `ASTMatchSwitchBuilder<Stmt>`.
-template <typename State, typename Result = void>
-using MatchSwitchBuilder = ASTMatchSwitchBuilder<Stmt, State, Result>;
-
 } // namespace dataflow
 } // namespace clang
 #endif // LLVM_CLANG_ANALYSIS_FLOWSENSITIVE_MATCHSWITCH_H_


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146864.508276.patch
Type: text/x-patch
Size: 2093 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230325/585354dd/attachment-0001.bin>