[clang-tools-extra] 3bff90e - [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

Michał Górny via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 24 12:25:49 PDT 2023


Author: Michał Górny
Date: 2023-03-24T20:25:31+01:00
New Revision: 3bff90e7e84aad6f0fddaf1d17a7db011052b95d

URL: https://github.com/llvm/llvm-project/commit/3bff90e7e84aad6f0fddaf1d17a7db011052b95d
DIFF: https://github.com/llvm/llvm-project/commit/3bff90e7e84aad6f0fddaf1d17a7db011052b95d.diff

LOG: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

Fix linking ClangdTests to specify the dependency on the private
clangTesting library via target_link_libraries() rather than
clang_target_link_libraries().  The latter uses libclang-cpp when
CLANG_LINK_CLANG_DYLIB is used, and clangTesting is not included
in this library.

This fixes d60d3455eb2b375d026a4aa74c4ba0c38f5d323c.

Differential Revision: https://reviews.llvm.org/D146427

Added: 
    

Modified: 
    clang-tools-extra/clangd/unittests/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/unittests/CMakeLists.txt b/clang-tools-extra/clangd/unittests/CMakeLists.txt
index 056e5803d711b..6d7bb59be3ab1 100644
--- a/clang-tools-extra/clangd/unittests/CMakeLists.txt
+++ b/clang-tools-extra/clangd/unittests/CMakeLists.txt
@@ -157,7 +157,6 @@ clang_target_link_libraries(ClangdTests
   clangLex
   clangSema
   clangSerialization
-  clangTesting
   clangTooling
   clangToolingCore
   clangToolingInclusions
@@ -172,6 +171,7 @@ target_link_libraries(ClangdTests
 
   clangDaemon
   clangIncludeCleaner
+  clangTesting
   clangTidy
   clangdSupport
   )


        


More information about the cfe-commits mailing list