[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

Zahira Ammarguellat via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 24 12:08:45 PDT 2023


zahiraam added a comment.

In D146148#4220268 <https://reviews.llvm.org/D146148#4220268>, @rjmccall wrote:

> Okay, so modifying `math.h` to use this attribute is acceptable?  That's great, that's definitely the best outcome for the compiler.
>
> Just a minor request about the diagnostic name, but otherwise LGTM.

Yes. Added the attribute inside the included math.h header file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146148/new/

https://reviews.llvm.org/D146148



More information about the cfe-commits mailing list