[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

[Tom Eccles via Phabricator via cfe-commits]

tblah added a comment.

Thanks for adding this flang.

Please could you add a test checking that the pass is actually run when the flag is given. For example, see the tests on this patch https://reviews.llvm.org/D146278



================
Comment at: flang/include/flang/Tools/CLOptions.inc:21
 #include "llvm/Support/CommandLine.h"
+#include <clang/Basic/DebugInfoOptions.h>
 
----------------
nit: clang is conceptually "above" LLVM in the dependency hierarchy:

https://llvm.org/docs/CodingStandards.html#include-style
>LLVM project and subproject headers should be grouped from most specific to least specific, for the same reasons described above. For example, LLDB depends on both clang and LLVM, and clang depends on LLVM. So an LLDB source file should include lldb headers first, followed by clang headers, followed by llvm headers, to reduce the possibility (for example) of an LLDB header accidentally picking up a missing include due to the previous inclusion of that header in the main source file or some earlier header file.


================
Comment at: flang/lib/Frontend/FrontendActions.cpp:58
 #include "llvm/Transforms/Utils/ModuleUtils.h"
+#include <clang/Basic/DebugInfoOptions.h>
 #include <memory>
----------------
nit: is this include required?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146814/new/

https://reviews.llvm.org/D146814