[PATCH] D146732: [include-cleaner] Attribute references to explicit specializations

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet marked 3 inline comments as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:82
+    if (llvm::isa<UsingShadowDecl, TypeAliasTemplateDecl>(ND) || !RD)
+      return ND;
+    return RD;
----------------
hokein wrote:
> We seem to miss a testcase for `TypeAliasTemplateDecl`, add one?
we already have one, pointed it there


================
Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:206
       template <typename> struct S {};
       template <typename T> $explicit^using foo = S<T>;)cpp",
            "^foo<int> x;");
----------------
this is where we have the template alias type test already


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146732/new/

https://reviews.llvm.org/D146732