[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 24 02:40:27 PDT 2023


owenpan added inline comments.


================
Comment at: clang/include/clang/Format/Format.h:2025
+  /// on a new line. When set to -1 (default), ``ContinuationIndentWidth`` is
+  /// used. \code
+  ///   AlignAfterOpenBracket: AlwaysBreak
----------------



================
Comment at: clang/include/clang/Format/Format.h:2037
+  /// \endcode
+  int DesignatedInitializerIndentWidth;
+
----------------
owenpan wrote:
> owenpan wrote:
> > 
> Please disregard my comment above.
Please add `\version 17`.


================
Comment at: clang/lib/Format/ContinuationIndenter.cpp:1659
       opensProtoMessageField(Current, Style)) {
+    const FormatToken *NextNoComment = Current.getNextNonComment();
     if (Current.opensBlockOrBlockTypeList(Style)) {
----------------
owenpan wrote:
> Can you also move it into the `else if` below to reduce the scope of the pointer? Please note the typo `NextNoComment`.
Please ignore my comment above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146101/new/

https://reviews.llvm.org/D146101



More information about the cfe-commits mailing list