[PATCH] D146713: [clang-tidy][NFC] Improve naming convention in google-readability-avoid-underscore-in-googletest-name
Carlos Galvez via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 23 09:35:25 PDT 2023
carlosgalvezp marked an inline comment as done.
carlosgalvezp added inline comments.
================
Comment at: clang-tools-extra/test/clang-tidy/checkers/google/avoid-underscore-in-googletest-name.cpp:10
TEST(TestCaseName, Illegal_TestName) {}
// CHECK-MESSAGES: :[[@LINE-1]]:20: warning: avoid using "_" in test name "Illegal_TestName" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name]
----------------
PiotrZSL wrote:
> Be consistent and change all those TestCaseName into TestSuiteName.
Thanks, I missed these. Fixed!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146713/new/
https://reviews.llvm.org/D146713
More information about the cfe-commits
mailing list