[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 23 07:22:17 PDT 2023


cor3ntin added a comment.

Sorry for the late review.
I think this makes sense generally, i just have one question



================
Comment at: clang/lib/Sema/SemaExpr.cpp:17979
+  if (Rec.ImmediateInvocationCandidates.size() > 1 ||
+      SemaRef.FailedImmediateInvocations.size()) {
 
----------------
Shouln't we clear `FailedImmediateInvocations` at the end of a full expression to avoid going there if there was an error in another expression


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146234/new/

https://reviews.llvm.org/D146234



More information about the cfe-commits mailing list