[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

[Hans Wennborg via Phabricator via cfe-commits]

hans added a comment.

Thanks, I like this.

Could you please also add tests in CodeGenCXX/dll{ex,im}port.cpp which verify that the IR looks right?



================
Comment at: clang/test/SemaCXX/dllexport.cpp:437
 
+class Base {};
+class __declspec(dllexport) ExportedClass {};
----------------
Is this one used somewhere?


================
Comment at: clang/test/SemaCXX/dllexport.cpp:439
+class __declspec(dllexport) ExportedClass {};
+class __declspec(dllimport) ImportedClass {};
+
----------------
Just to double check: this case (non-template base class) worked before this patch too, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146338/new/

https://reviews.llvm.org/D146338