[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

Martin Böhme via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 23 00:37:01 PDT 2023


mboehme marked an inline comment as done.
mboehme added a comment.

In D146514#4213302 <https://reviews.llvm.org/D146514#4213302>, @xazax.hun wrote:

> In D146514#4212528 <https://reviews.llvm.org/D146514#4212528>, @mboehme wrote:
>
>> No, I think this is a different case.
>
> Sorry, I might have been unclear. I 100% agree that these are different cases. I was wondering whether we can/should have a single code path supporting both. But I do not insist since we do not seem to have precedent for the scenario I mentioned and do not want to block anything based on hypotheticals.

Got it, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146514/new/

https://reviews.llvm.org/D146514



More information about the cfe-commits mailing list