[PATCH] D146501: [clang-format] Don't format already formatted integer literals

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 22 23:06:50 PDT 2023


owenpan added a comment.

In D146501#4209026 <https://reviews.llvm.org/D146501#4209026>, @MyDeveloperDay wrote:

> Do we have any unit tests for this that we can pump a shed load of examples at?

I would need to make `checkSeparator()` public to add unit tests for it. Even then, the tests would be redundant to the added assertion (`assert(Formatted != Text);` on line 146), which would have caught the bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146501/new/

https://reviews.llvm.org/D146501



More information about the cfe-commits mailing list