[PATCH] D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name
Richard via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 22 15:15:59 PDT 2023
LegalizeAdulthood added inline comments.
================
Comment at: clang-tools-extra/test/clang-tidy/checkers/google/avoid-underscore-in-googletest-name.cpp:90
// Underscores are allowed to disable a test with the DISABLED_ prefix.
-// https://github.com/google/googletest/blob/master/googletest/docs/faq.md#why-should-test-suite-names-and-test-names-not-contain-underscore
+// https://google.github.io/googletest/faq.html#why-should-test-suite-names-and-test-names-not-contain-underscore
TEST(TestCaseName, TestName) {}
----------------
PiotrZSL wrote:
> Would be good if this link would exist also in documentation for this check.
My experience has been that these external links move around with gtest and are a source of churn.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146655/new/
https://reviews.llvm.org/D146655
More information about the cfe-commits
mailing list