[PATCH] D146041: Fix weirdly apologetic diagnostic messages

Wed Mar 22 13:23:30 PDT 2023

manas added a comment.

Hi, I came across this due to changes in Static Analyzer. One of the changes is not related to the Github issue mentioned above. Maybe we can drop that file?

================
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1214-1215
         StringRef Note = Case.getNote();
         const NoteTag *Tag = C.getNoteTag(
-            // Sorry couldn't help myself.
             [Node, Note]() -> std::string {
               // Don't emit "Assuming..." note when we ended up
----------------
This is unrelated to the above mentioned issue.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146041/new/

https://reviews.llvm.org/D146041