[PATCH] D145813: [clang-format] Respect Cpp11BraceListStyle when aligning array of structures

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 22 03:44:40 PDT 2023


MyDeveloperDay added inline comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:20273
+  Style.ColumnLimit = 20;
+  EXPECT_EQ(
+      "demo = std::array<\n"
----------------
hch12907 wrote:
> MyDeveloperDay wrote:
> > any reason you didn't use verifyFormat here?
> No particular reason - I simply copied other tests and modified them to suit the Cpp11BracedListStyle == false case, and one of those tests used EXPECT_EQ.
> 
> Should I change it to verifyFormat?
yes please as this tests the code getting messup and putting it back to normal


================
Comment at: clang/unittests/Format/FormatTest.cpp:20276
+      "    struct test, 3>{\n"
+      "  test{\n"
+      "       56,    23,\n"
----------------
just because we go over the limit do you think its correct that it pushes this back?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145813/new/

https://reviews.llvm.org/D145813



More information about the cfe-commits mailing list