[PATCH] D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks.



================
Comment at: clang/docs/ReleaseNotes.rst:222-223
   template function.
+- Fix coroutines issue where return object is being prematurely
+  converted. This fixes
+  (`#56532 <https://github.com/llvm/llvm-project/issues/56532>`_) in
----------------
I feel it would slightly better to claim that the RVO is till performed if the return type matches with the type of `get_return_object()`. So that the users won't get worries.


================
Comment at: clang/test/CodeGenCoroutines/coro-gro.cpp:107
+}
\ No newline at end of file

----------------
Add a newline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145641/new/

https://reviews.llvm.org/D145641