[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11
Alex Bradbury via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 21 11:27:11 PDT 2023
asb added a comment.
In principle I think this is good, but I see two considerations:
1. Sam was right that there's an ability to change the register after the fact, but 2.5 years have passed since then. We should make a good faith attempt to see if any downstream users are relying on the current ABI (e.g. the original contributors - @zzheng and @apazos).
2. Now that the issue has been raised in the psABI / toolchain-sig, it would be good if there were consensus on the "platform register" rather than changing this multiple times if some different register is decided.
I'd hope we can resolve this quickly enough that we don't need to consider e.g. adding a way to select the shadow call stack register, but if you _need_ this quickly to iterate on Android/Fuchsia then that might be the easiest route to land something very rapidly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146463/new/
https://reviews.llvm.org/D146463
More information about the cfe-commits
mailing list