[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

[Martin Böhme via Phabricator via cfe-commits]

mboehme marked an inline comment as done.
mboehme added inline comments.


================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:399
+template <class ValueT>
+ValueT &getValueFromDecl(ASTContext &ASTCtx, const Environment &Env,
+                         llvm::StringRef Name) {
----------------
gribozavr2 wrote:
> getValueForDecl?
> 
> A value corresponds to a decl, a value for the decl.
> 
> "From" suggests that the value is inside the decl, or that we transform the decl into a value.
Good point -- done!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146514/new/

https://reviews.llvm.org/D146514