[PATCH] D146434: [clang-format] Fix support for ObjC blocks with pointer return types

[Jared Grubb via Phabricator via cfe-commits]

jaredgrubb added inline comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:22178
                "});");
-  verifyFormat("Block b = ^int *(A *a, B *b) {}");
+  verifyFormat("Block b = ^int *(A *a, B *b) {\n"
+               "};");
----------------
MyDeveloperDay wrote:
> I don’t like us changing tests
Normally I would agree, but in this case, this is a bug-fix for the test as well. 

If you look at the `verifyFormat` just below this one, its braces are broken across separate lines. The inconsistency between these two tests was due to the difference in the block's return type (pointer vs non-pointer). 

My patch corrects exactly that inconsistency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146434/new/

https://reviews.llvm.org/D146434