[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 20 16:20:31 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:58
 
   const auto *RVFI = MF.getInfo<RISCVMachineFunctionInfo>();
   if (RVFI->useSaveRestoreLibCalls(MF)) {
----------------
paulkirth wrote:
> craig.topper wrote:
> > Can you add a FIXME here? Using x27 should hopefully remove this restriction
> I've added the FIXME, but do we just want to remove this now? or is there some issues or chang under review I can ref in the FIXME?
We can remove it, but we should add a test for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146463/new/

https://reviews.llvm.org/D146463



More information about the cfe-commits mailing list