[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.
Artem Belevich via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 20 15:23:51 PDT 2023
tra added a comment.
In D146448#4207591 <https://reviews.llvm.org/D146448#4207591>, @yaxunl wrote:
> Do you know whether the issue happens to HIP too? Thanks.
Possibly, but I'm unable to reproduce the crash: https://godbolt.org/z/Gsx9sWG4v
The value cached by KernelHandles in HIP is the the manually created 'Var' and not the function itself. I don't think it ever changes outside of this function.
However, `KernelStubs` would still point to the original `F`, and that may potentially be left dangling. Perhaps I should always update both handles and stubs if `F` changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146448/new/
https://reviews.llvm.org/D146448
More information about the cfe-commits
mailing list