[PATCH] D146377: [clangd] Remove reundant use of getSpellingLoc()
Nathan Ridge via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 20 11:52:41 PDT 2023
This revision was automatically updated to reflect the committed changes.
Closed by commit rG57bfe25574a0: [clangd] Remove reundant use of getSpellingLoc() (authored by nridge).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146377/new/
https://reviews.llvm.org/D146377
Files:
clang-tools-extra/clangd/FindSymbols.cpp
clang-tools-extra/clangd/XRefs.cpp
Index: clang-tools-extra/clangd/XRefs.cpp
===================================================================
--- clang-tools-extra/clangd/XRefs.cpp
+++ clang-tools-extra/clangd/XRefs.cpp
@@ -1611,8 +1611,8 @@
ASTContext &Ctx = ND.getASTContext();
auto &SM = Ctx.getSourceManager();
SourceLocation NameLoc = nameLocation(ND, Ctx.getSourceManager());
- SourceLocation BeginLoc = SM.getSpellingLoc(SM.getFileLoc(ND.getBeginLoc()));
- SourceLocation EndLoc = SM.getSpellingLoc(SM.getFileLoc(ND.getEndLoc()));
+ SourceLocation BeginLoc = SM.getFileLoc(ND.getBeginLoc());
+ SourceLocation EndLoc = SM.getFileLoc(ND.getEndLoc());
const auto DeclRange =
toHalfOpenFileRange(SM, Ctx.getLangOpts(), {BeginLoc, EndLoc});
if (!DeclRange)
Index: clang-tools-extra/clangd/FindSymbols.cpp
===================================================================
--- clang-tools-extra/clangd/FindSymbols.cpp
+++ clang-tools-extra/clangd/FindSymbols.cpp
@@ -223,8 +223,8 @@
std::optional<DocumentSymbol> declToSym(ASTContext &Ctx, const NamedDecl &ND) {
auto &SM = Ctx.getSourceManager();
- SourceLocation BeginLoc = SM.getSpellingLoc(SM.getFileLoc(ND.getBeginLoc()));
- SourceLocation EndLoc = SM.getSpellingLoc(SM.getFileLoc(ND.getEndLoc()));
+ SourceLocation BeginLoc = SM.getFileLoc(ND.getBeginLoc());
+ SourceLocation EndLoc = SM.getFileLoc(ND.getEndLoc());
const auto SymbolRange =
toHalfOpenFileRange(SM, Ctx.getLangOpts(), {BeginLoc, EndLoc});
if (!SymbolRange)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146377.506672.patch
Type: text/x-patch
Size: 1498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230320/4a82aa97/attachment.bin>
More information about the cfe-commits
mailing list