[PATCH] D144987: [clang][dataflow] Fix missed fields in field set construction.

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 20 10:33:05 PDT 2023


gribozavr2 added inline comments.


================
Comment at: clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp:141
+     };
+     S foo();
+  )cc";
----------------
ymandel wrote:
> gribozavr2 wrote:
> > Is `foo()` used for anything in this test?
> not that I can see. looks left over from some previous version. want to remove it?
Actually it is load-bearing: the qualType() matcher below matches the return type of the function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144987/new/

https://reviews.llvm.org/D144987



More information about the cfe-commits mailing list