[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1714
 /// Check whether a function's parameter types are all literal types. If so,
 /// return true. If not, produce a suitable diagnostic and return false.
 static bool CheckConstexprParameterTypes(Sema &SemaRef,
----------------
shafik wrote:
> This comment seems to no longer be true since we don't emit a diagnostic for the `!PD` case.
Good catch! Updated the comment.


================
Comment at: clang/test/SemaCXX/crash-params.cpp:3
+
+template <bool>
+int foo() {
----------------
shafik wrote:
> If this test really does not fit into any other test set the please rename the test file `GH61441.cpp` so we know it is a regression test for that github bug report.
> 
> Otherwise if we add a test from a bug report into an existing test file then we wrap it something like `namespace GH61441` so we know that test is a regression test for github bug 61441.
I am not very good at navigating the test files and couldn't find a good existing file for the test.
Ended up creating `GH61441.cpp`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146426/new/

https://reviews.llvm.org/D146426