[PATCH] D146420: Document the Clang policies on claiming support for a feature

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 20 09:28:03 PDT 2023


cor3ntin added inline comments.


================
Comment at: clang/docs/InternalsManual.rst:3285
+  * Are there known issues with the feature that reject valid code?
+  * Are there known issues that fail to reject invalid code?
+  * Are there known crashes, failed assertions, or miscompilations?
----------------
aaron.ballman wrote:
> cor3ntin wrote:
> > aaron.ballman wrote:
> > > cor3ntin wrote:
> > > > any way to rephrase that, "that cause clamg to reject" maybe?
> > > Sure, we can go with "accept invalid code" instead of "fail to reject invalid".
> > is the issue the thing that accepts the code? that's what bugs me
> I'm trying to list out two problems separately: the first is when we reject code that we should be accepting, and the second is when we accept code that we should be rejecting. I think I see where your confusion is coming from, how about:
> ```
> * Are there known issues where we reject valid code that should be accepted?
> * Are there known issues where we accept invalid code that should be rejected?
> ```
that sounds good to me!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146420/new/

https://reviews.llvm.org/D146420



More information about the cfe-commits mailing list