[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 20 09:07:06 PDT 2023


shafik added inline comments.


================
Comment at: clang/test/SemaCXX/crash-params.cpp:3
+
+template <bool>
+int foo() {
----------------
If this test really does not fit into any other test set the please rename the test file `GH61441.cpp` so we know it is a regression test for that github bug report.

Otherwise if we add a test from a bug report into an existing test file then we wrap it something like `namespace GH61441` so we know that test is a regression test for github bug 61441.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146426/new/

https://reviews.llvm.org/D146426



More information about the cfe-commits mailing list