[PATCH] D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 20 08:04:32 PDT 2023


mgorny created this revision.
mgorny added reviewers: DmitryPolukhin, kadircet, tstellar, MaskRay.
Herald added subscribers: mikhail.ramalho, arphaman.
Herald added a project: All.
mgorny requested review of this revision.
Herald added a subscriber: ilya-biryukov.
Herald added a project: clang-tools-extra.

Fix linking ClangdTests to specify the dependency on the private
clangTesting library via target_link_libraries() rather than
clang_target_link_libraries().  The latter uses libclang-cpp when
CLANG_LINK_CLANG_DYLIB is used, and clangTesting is not included
in this library.

This fixes d60d3455eb2b375d026a4aa74c4ba0c38f5d323c <https://reviews.llvm.org/rGd60d3455eb2b375d026a4aa74c4ba0c38f5d323c>.


https://reviews.llvm.org/D146427

Files:
  clang-tools-extra/clangd/unittests/CMakeLists.txt


Index: clang-tools-extra/clangd/unittests/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/unittests/CMakeLists.txt
+++ clang-tools-extra/clangd/unittests/CMakeLists.txt
@@ -157,7 +157,6 @@
   clangLex
   clangSema
   clangSerialization
-  clangTesting
   clangTooling
   clangToolingCore
   clangToolingInclusions
@@ -172,6 +171,7 @@
 
   clangDaemon
   clangIncludeCleaner
+  clangTesting
   clangTidy
   clangdSupport
   )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146427.506593.patch
Type: text/x-patch
Size: 489 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230320/3f41c3b4/attachment.bin>


More information about the cfe-commits mailing list