[PATCH] D146420: Document the Clang policies on claiming support for a feature

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: clang/docs/InternalsManual.rst:3276
+Some of these feature tests are standardized, like ``__has_cpp_attribute`` or
+``__cpp_decltype``, while others are Clang extensions, like ``__has_builtin``.
+The common theme among all the various feature tests is that they are a utility
----------------
Phab won't let me suggest it, but instead of `__cpp_decltype` (which to my mind, suggested it was a function-style FTM?), I might suggest something like `__cpp_lambdas`.


================
Comment at: clang/docs/InternalsManual.rst:3289
+
+If the answer to any of these is "yes", you should either not define the
+feature test macro or have very strong rationale for why the issues should not
----------------
you -> we?  Rest of the doc is in 3rd person, this is in 2nd?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146420/new/

https://reviews.llvm.org/D146420