[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

Andrew Kaster via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 19 11:20:32 PDT 2023


ADKaster added inline comments.


================
Comment at: clang-tools-extra/clangd/Headers.cpp:353
+  if (IsSystem ||
+      IncludeDelimiter == Config::IncludeDelimiterPolicy::AlwaysBrackets)
     Suggested = "<" + Suggested + ">";
----------------
I couldn't tell looking at other code in clangd whether it would be preferred to fetch the value from `Config::current()` here every time, or if having the option saved as a member variable of the IncludeInserter is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145843/new/

https://reviews.llvm.org/D145843



More information about the cfe-commits mailing list